Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #7099 Update ID & links for beacon host fonts #7100

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Closes #7099 Update ID & links for beacon host fonts #7100

merged 1 commit into from
Nov 14, 2024

Conversation

remyperona
Copy link
Contributor

Description

Fixes #7099

Add Beacon IDs and links for Host fonts locally

Type of change

Detailed scenario

The docs should be linked to the more info link in the feature description section

Technical description

Documentation

Add the links & IDs to the Beacon class

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Nov 12, 2024
@remyperona remyperona added this to the 3.18 milestone Nov 12, 2024
@remyperona remyperona requested a review from a team November 12, 2024 16:38
@remyperona remyperona self-assigned this Nov 12, 2024
@remyperona remyperona linked an issue Nov 12, 2024 that may be closed by this pull request
3.18 - Admin UI documentation part #7099
Open
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8b7db2e1 ✅ 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8b7db2e) Report Missing Report Missing Report Missing
Head commit (4859980) 38163 16712 43.79%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7100) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@jeawhanlee jeawhanlee merged commit 9a55086 into feature/host-google-fonts Nov 14, 2024
13 of 14 checks passed
@jeawhanlee jeawhanlee deleted the task/7099-beacon-links branch November 14, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeawhanlee jeawhanlee jeawhanlee approved these changes

Assignees

@remyperona remyperona

Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
3.18
Development

Successfully merging this pull request may close these issues.

3.18 - Admin UI documentation part
2 participants
@remyperona @jeawhanlee